Skip to content

Use ha-dialog for dialog-area-registry-detail#7508

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
joshmcrty:dialog-area-registry-detail
Oct 28, 2020
Merged

Use ha-dialog for dialog-area-registry-detail#7508
bramkragten merged 1 commit intohome-assistant:devfrom
joshmcrty:dialog-area-registry-detail

Conversation

@joshmcrty
Copy link
Contributor

Proposed change

This replaces the use of ha-paper-dialog with ha-dialog for the Area settings dialog on the Area registry detail page. It also adds a public closeDialog method per #6138

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Create a new area on the Areas page, or click on an area on the Areas page, then click on the gear icon in the top right corner to open the new dialog.

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit a721838 into home-assistant:dev Oct 28, 2020
@joshmcrty joshmcrty deleted the dialog-area-registry-detail branch October 28, 2020 15:44
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants